Publish metadata #812
Merged
Publish metadata #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! Does publish on the registry wait to return 200 until the dat metadata is downloaded? Couldn't quite see in the code. |
|
It gives it 5 seconds, and then if it doesn't get any entries it returns an error with message 'timed out'. https://github.com/datproject/dat-registry-api/blob/c9a01211fd50b456ab269a066ffdc7d017a9fd4f/api/dats.js#L44 |
|
@joehand just committed a little bit on an error message, what do you think? |
|
Looks good and ready to merge but I want to see what @Karissa says about uploading the full dat.json bug: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This along with https://github.com/datproject/datproject.org/pull/594 will fix #803. That means when you
dat publish, the registry will automatically pick up your metadata and have it ready for display so that even if the dat is down, we have a first picture of what the dat is. That also makes sure that the url is legit before allowing the publish to happen.It also bumps dat-registry to 3.0.3 for a tiny bug fix.